[dns-operations] Bind 9.8.0 intermittent problem with non-recursive responses

[Mark Andrews]

In the end it was a simple bug.  dbversion->queryok was not being
set to ISC_TRUE when it should have been (second change).
Initialising dbversion->queryok to ISC_FALSE made the failure
deterministic.

This will be in BIND 9.8.1 final.  BIND 9.8.1b1 is already cut
and will need this to be applied.

Mark

Index: bin/named/query.c
===================================================================
RCS file: /proj/cvs/prod/bind9/bin/named/query.c,v
retrieving revision 1.353.8.2
diff -u -r1.353.8.2 query.c
--- bin/named/query.c   18 Feb 2011 15:27:58 -0000      1.353.8.2
+++ bin/named/query.c   20 May 2011 04:11:20 -0000
@@ -637,6 +637,7 @@
                dns_db_attach(db, &dbversion->db);
                dns_db_currentversion(db, &dbversion->version);
                dbversion->acl_checked = ISC_FALSE;
+               dbversion->queryok = ISC_FALSE;
                ISC_LIST_APPEND(client->query.activeversions,
                                dbversion, link);
        }
@@ -768,6 +769,7 @@
                dbversion->queryok = ISC_FALSE;
                return (DNS_R_REFUSED);
        }
+       dbversion->queryok = ISC_TRUE;
 
  approved:
        /* Transfer ownership, if necessary. */

-- 
Mark Andrews, ISC
1 Seymour St., Dundas Valley, NSW 2117, Australia
PHONE: +61 2 9871 4742                 INTERNET: marka at isc.org